fix pulse buffering #899
Merged
fix pulse buffering #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the simple API is indeed simple, but does not provide flexible control
over audio writing, and can notably lead to underruns. This is
essentially the same as before, except that we keep writing audio data
as much as possible, since we can now control interrupting it from
spd_pa_simple_flush.
What we want is:
- Reduce server-side pre-buffering to min_audio_length
- So playback can start as soon as reasonably possible without risking
underruns
- Push as much data to the server as possible
- So we avoid underruns
- Be able to stop as quickly as possible
Inlining the pulse simple implementation is not that complex and provides
best flexibility to achieve that.
That will also allow use to use pa_stream_get_time etc. to get the
playback position for proper indexing.
Fixes brailcom#885
We are actually fine with the server using a long buffer. What we however want is for playback to start early. Flushing will discard the long buffer anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.