Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix daemon mode on macOS with libao #910

Closed
wants to merge 1 commit into from
Closed

server: fix daemon mode on macOS with libao #910

wants to merge 1 commit into from

Conversation

mohd-akram
Copy link
Contributor

@mohd-akram mohd-akram commented May 2, 2024

libao calls into macOS frameworks which do not behave well if exec is not called after fork.

Fixes #907

libao calls into macOS frameworks which do not behave well if exec is
not called after fork.
@sthibaul
Copy link
Collaborator

I reworked things a bit, and notably split the changes into separate commits, to much clearly show what is happening here, so further bisecting etc. will be much easier.

Thanks!

@sthibaul sthibaul closed this May 10, 2024
@mohd-akram mohd-akram deleted the fix-daemon-macos branch May 10, 2024 18:10
@mohd-akram
Copy link
Contributor Author

Thanks! Regarding the modules, is there a reason for loading them before the fork? I noticed speechd waits a bit before going into daemon mode, and moving the module loading after resolves that. It also makes the modules children of the daemon process rather than not.

@sthibaul
Copy link
Collaborator

Regarding the modules, is there a reason for loading them before the fork?

It allows to see the failure to load any module at all, before speechd goes to background and is not to be seen again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No audio on macOS using espeak-ng
2 participants