Error popups #115
Open
Error popups #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MKuijpers
requested review from
InvictusRMC and
PJvanderLaan
and removed request for
PJvanderLaan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Merge #113 first, this branch is based onmvp-screen-changes, diff: mvp-screen-changes...error-popupsCloses #111
Adds some basic toast error popups for the following operations if they fail:
Also changed the ConfirmModal to support rendering as a component with a
visibleprop, instead of just using ashowConfirmModalmethod. Allowing for dynamic confirm modals, as is now used in the modal to delete stickers. A loading indicator is shown while the sticker is deleted.