Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Deeplinking: Inviting/joining other packs #77

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

MKuijpers
Copy link
Collaborator

@MKuijpers MKuijpers commented Apr 3, 2021

Important: Merge #113 first, this branch is based on mvp-screen-changes, actual diff: mvp-screen-changes...deeplinking


Closes #44, Closes #97

TODOS BEFORE MERGING:

  • Test on live server

Deeplinking for iOS can be added in a new PR: #44 (comment)

Changes

  • Setup deeplinking responding to:
    • https://www.stickr.cf
    • kangaroo:// (not used, added for future use)
  • Share packs:
    • Create invite
    • Copies invite URL to clipboard
  • Join packs:
    • Use invite URL (example: https://www.stickr.cf/invite/{inviteId})
    • Device shows you a popup, asking you whether to open it with the app or a browser:
      • App: Go to join screen (UI not final)
      • Browser: Could add a preview screen on the website, but for now a nice 404 screen
    • Join pack

Notes

  • Invites do not expire yet
  • Changed stickerpack screen query to ownAndJoinedStickerPacks from myStickerPacks
  • Share button is shown for non-owners, should be hidden in the future

Screenshot

@MKuijpers MKuijpers changed the title WIP: Deeplinking: Inviting/joining other packs Android Deeplinking: Inviting/joining other packs Apr 17, 2021
@MKuijpers MKuijpers added the app label Jan 19, 2023
@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
kangaroo ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 1, 2023 at 10:26PM (UTC)

@MKuijpers MKuijpers changed the title Android Deeplinking: Inviting/joining other packs Android Deeplinking: Inviting/joining other packs (depends on #113) Jan 22, 2023
@MKuijpers MKuijpers changed the title Android Deeplinking: Inviting/joining other packs (depends on #113) Android Deeplinking: Inviting/joining other packs Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kick users from packs Sharing packs / Deeplinking
2 participants