Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (ci): add node v20 to build matrix #3148

Merged
merged 3 commits into from
Mar 15, 2024
Merged

chore (ci): add node v20 to build matrix #3148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3542fd7
chore (ci): add node v20 to build matrix
Feb 19, 2024
1586c05
Merge branch 'master' into ci-node-20
Mar 15, 2024
5cf45d7
skip pg-native tests on node 20
Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ jobs:
- '14'
- '16'
- '18'
- '20'
os:
- ubuntu-latest
name: Node.js ${{ matrix.node }} (${{ matrix.os }})
Expand All @@ -54,6 +55,7 @@ jobs:
PGTESTNOSSL: 'true'
SCRAM_TEST_PGUSER: scram_test
SCRAM_TEST_PGPASSWORD: test4scram
TEST_SKIP_NATIVE: ${{ matrix.node == 20 }}
steps:
- name: Show OS
run: |
Expand Down
4 changes: 4 additions & 0 deletions packages/pg/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,14 @@ test-missing-native:

test-native: test-connection
@echo "***Testing native bindings***"
ifeq ($(TEST_SKIP_NATIVE), true)
@echo "***Skipping tests***"
else
@npm i --no-save pg-native
@find test/native -name "*-tests.js" | $(node-command)
@find test/integration -name "*-tests.js" | $(node-command) native
@npm uninstall pg-native
endif

test-integration: test-connection
@echo "***Testing Pure Javascript***"
Expand Down