Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native extension build on M1 macOS (Ruby 3+) by adjusting compiler flags #193

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix native extension build on M1 macOS (Ruby 3+) by adjusting compiler flags #193

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e68be1
bump version
tenderlove Jul 10, 2024
92a20eb
Fix native extension build on Apple Silicon (M1) with Ruby 3+ by forc…
eli-barkov-talogy Feb 7, 2025
5b717f0
Merge branch 'brianmario:master' into v0.7.10-compatibillity-for-m1
eli-barkov-talogy Feb 10, 2025
75c063d
removed unnecessary code
Feb 10, 2025
feab366
Merge remote-tracking branch 'origin/v0.7.10-compatibillity-for-m1' i…
Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions ext/charlock_holmes/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,18 @@
# ICU dependency
#

# If on Apple Silicon (M1, host_cpu "arm64") and Ruby version is 3.0.0 or greater,
# then force the C++ compiler to clang++.
FORCE_COMPATIBILITY_APPLE_M1_RUBY_3 = (RbConfig::CONFIG['host_cpu'] == 'arm64' && Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.0.0')) || false

ldflags = cppflags = nil

if RbConfig::CONFIG["host_os"] =~ /darwin/
begin
brew_prefix = `brew --prefix icu4c`.chomp
ldflags = "#{brew_prefix}/lib"
cppflags = "#{brew_prefix}/include"
pkg_conf = "#{brew_prefix}/lib/pkgconfig"
ldflags = "#{brew_prefix}/lib"
cppflags = "#{brew_prefix}/include"
pkg_conf = "#{brew_prefix}/lib/pkgconfig"
# pkg_config should be less error prone than parsing compiler
# commandline options, but we need to set default ldflags and cpp flags
# in case the user doesn't have pkg-config installed
Expand Down Expand Up @@ -56,7 +60,7 @@

# Pass -x c++ to force gcc to compile the test program
# as C++ (as it will end in .c by default).
compile_options = +"-x c++"
compile_options = +"-x c++" unless FORCE_COMPATIBILITY_APPLE_M1_RUBY_3

icu_requires_version_flag = checking_for("icu that requires explicit C++ version flag") do
!try_compile(minimal_program, compile_options)
Expand All @@ -67,8 +71,7 @@
checking_for("icu that compiles with #{std} standard") do
flags = compile_options + " -std=#{std}"
if try_compile(minimal_program, flags)
$CPPFLAGS << flags

$CFLAGS << flags
true
end
end
Expand Down
Loading