-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:add support for manualReloadFromPropChanges prop #67
Merged
bc-paul
merged 2 commits into
brightcove:master
from
bc-paul:manualReloadFromPropChanges
Jan 31, 2020
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,13 +45,18 @@ class ReactPlayerLoader extends React.Component { | |
* @param {Object} [props.attrs] | ||
* Used to set attributes on the component element that contains the | ||
* embedded Brightcove Player. | ||
* | ||
* @param {boolean} [props.manualReloadFromPropChanges] | ||
* Used to specify if reloading the player after prop changes will be handled manually. | ||
* | ||
*/ | ||
constructor(props) { | ||
super(props); | ||
this.refNode = null; | ||
this.setRefNode = ref => { | ||
this.refNode = ref; | ||
}; | ||
this.loadPlayer = this.loadPlayer.bind(this); | ||
} | ||
|
||
/** | ||
|
@@ -123,6 +128,7 @@ class ReactPlayerLoader extends React.Component { | |
// Delete props that are not meant to be passed to player-loader. | ||
delete options.attrs; | ||
delete options.baseUrl; | ||
delete options.manualReloadFromPropChanges; | ||
|
||
// If a base URL is provided, it should only apply to this player load. | ||
// This means we need to back up the original base URL and restore it | ||
|
@@ -325,17 +331,32 @@ class ReactPlayerLoader extends React.Component { | |
const previous = prevProps[key]; | ||
const current = this.props[key]; | ||
|
||
// Do not compare functions | ||
if (typeof current === 'function') { | ||
return acc; | ||
} | ||
|
||
if (typeof current === 'object') { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should make sure we don't error with |
||
if (JSON.stringify(current) !== JSON.stringify(previous)) { | ||
acc[key] = true; | ||
} | ||
|
||
return acc; | ||
} | ||
|
||
if (current !== previous) { | ||
acc[key] = true; | ||
} | ||
|
||
return acc; | ||
}, {}); | ||
|
||
// Dispose and recreate the player if any changed keys cannot be handled. | ||
if (Object.keys(changes).some(k => UPDATEABLE_PROPS.indexOf(k) === -1)) { | ||
this.loadPlayer(); | ||
return; | ||
if (!this.props.manualReloadFromPropChanges) { | ||
// Dispose and recreate the player if any changed keys cannot be handled. | ||
if (Object.keys(changes).some(k => UPDATEABLE_PROPS.indexOf(k) === -1)) { | ||
this.loadPlayer(); | ||
return; | ||
} | ||
} | ||
|
||
this.updatePlayer(changes); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
props that are
?