Dockerfile: remove node runtime #283

willholley · 2024-10-18T21:51:23Z

Why:

The websites served under WebDashboard and
givtcp-vuejs are status - there's no need to have
nodejs at runtime. Removing nodejs / npm and the
build-time dependencies shaves around 500MB from
the docker image (as well as reducing the CVE
surface).

How:

Adds a builder stage which compiles givtcp-vuejs. The resultant static files are copied into the final image.
Removes npm and http-server from the runtime image.
Adds exclusions to .dockerignore for some of the Webdashboard files that have no runtime purpose.
Updates startup.py to write out nginx configuration that serves WebDashboard as a static site. This is only really needed because the dashboard port is configurable/toggleable - else we could just define this in the standard ingress.conf.

Updates for WebDashboard

Why: The websites served under WebDashboard and givtcp-vuejs are status - there's no need to have nodejs at runtime. Removing nodejs / npm and the build-time dependencies shaves around 500MB from the docker image (as well as reducing the CVE surface). How: * Adds a builder stage which compiles givtcp-vuejs. The resultant static files are copied into the final image. * Removes npm and http-server from the runtime image. * Adds exclusions to .dockerignore for some of the Webdashboard files that have no runtime purpose. * Updates startup.py to write out nginx configuration that serves WebDashboard as a static site. This is only really needed because the dashboard port is configurable/toggleable - else we could just define this in the standard ingress.conf.

startup.py

britkat1980 and others added 7 commits October 1, 2024 09:52

Update README.md

031b03c

Update README.md

6abfa43

Fix GivTCP using wrong reference to WebDashboard

ac2bfe8

Update WebDashboard

5f48d03

Replace npm module "serve" with "http-server"

8827830

Merge pull request britkat1980#259 from DanielGallo:dev-v3

fe07cd5

Updates for WebDashboard