Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CHR2 and END2 from INS in CleanVcf #631

Merged
merged 2 commits into from
May 2, 2024

Conversation

epiercehoffman
Copy link
Collaborator

@epiercehoffman epiercehoffman commented Jan 29, 2024

Updates

  • Remove CHR2 and END2 from INS in CleanVcf. In most cases, these fields duplicate information in CHROM and POS. In other cases, they duplicate information in SOURCE. The inconsistent use is confusing and unnecessary.
  • Do not require CHR2 in svtk. If CHR2 is not present, use CHR2=CHROM. This was causing issues when running svtk vcfcluster after removing CHR2 from INS.

Testing

  • Built updated docker image, ran CleanVcf, and verified CHR2 and END2 tags were not present in INS records
  • Ran reclustering workflow with updated docker image and it resolved the error message about CHR2<CHROM and the subsequent error message about the missing CHR2 field
  • Validated all WDLs and JSONs with womtool and Terra validation script

@epiercehoffman epiercehoffman marked this pull request as draft February 5, 2024 21:51
@epiercehoffman epiercehoffman marked this pull request as ready for review February 6, 2024 17:48
Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been rolling with this for a while now so I'd assume it's okay still. Did it cause any issues with CPX records for other downstream workflows like ManualReview?

@epiercehoffman
Copy link
Collaborator Author

We've been rolling with this for a while now so I'd assume it's okay still. Did it cause any issues with CPX records for other downstream workflows like ManualReview?

We had to update ManualReview to accommodate #583. I don't recall any additional issues that arose as a result of altering the INS records (this PR). The issues we had with that were related to reclustering, and I addressed those as part of this PR.

@epiercehoffman epiercehoffman merged commit d3514d4 into main May 2, 2024
4 checks passed
@epiercehoffman epiercehoffman deleted the eph_ins_remove_chr2_end2 branch May 2, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants