Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MELT scripts independent of the execution path. #665

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Apr 10, 2024

MELT scripts build logic dependent on the script invocation path. The invocation path on Cromwell is a deployment-specific configuration, and currently, the default settings on GCP and Azure differ, which breaks MELT execution. We have two possible tracks to address this: (1) update the scripts to match the currently configured invocation path on Azure and GCP, or (2) update the scripts to be independent of the invocation path. This PR implements the latter approach as it seems more portable and invariant to deployment-specific configurations of Cromwell.

Specifically, this PR implements the following:

  • Remove invocation path-dependent logic from MELT script and WDL;
  • Update MELT docker and update dockers*.json accordingly.

The changes were successfully tested on GCP and Azure:

  • GCP: 77c2629e-a0a7-4701-a3c0-97f7cd7a0aac;
  • Azure: e168090f-c684-474e-84fd-6b51d0c3ddd0.

@VJalili VJalili requested a review from mwalker174 April 10, 2024 17:16
@VJalili VJalili marked this pull request as ready for review April 10, 2024 17:16
Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@VJalili
Copy link
Member Author

VJalili commented Apr 16, 2024

Thank you, @mwalker174!

@VJalili VJalili merged commit b8be7e3 into broadinstitute:main Apr 16, 2024
5 checks passed
@VJalili VJalili deleted the melt-path branch April 16, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants