-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PD-2474: Remove reads from MT genes in Tagsort metrics #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ekiernan
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looked good! Thank you for demoing. I think as long as the number of MT reads matches what is expected as discussed, this can be merged.
khajoue2
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove reads on MT genes from the intronic, exonic, and intergenic counts in Optimus/Multiome. To do this, we did the following:
Added the protected variables
std::unordered_set<std::string> mito_genes_
to the classMetricGatherer
.mito_genes_
are a set of MT genesAdded the following additional input parameters to the
MetricGatherer
class: TagOrder tag_order, std::string gtf_file, std::string mitochondrial_gene_names_filename.Added function
isMitochondrial
to the classMetricGatherer
which returns whether or not a gene is mitochondrial based on the tag_order.Moved function
getInterestingMitochondrialGenes
in theMetricGatherer
constructor.Function
parseAlignedReadFields
in theMetricGatherer
class.isMitochondrial
) to check if the gene is mitochondrial or not before counting the number of reads_mapped_uniquely_, reads_mapped_exonic_, reads_mapped_intronic_, reads_mapped_intronic_as_ and reads_mapped_multiple_.ingestLine
in theCellMetricGatherer
class.isMitochondrial
) in if statement to check if gene is mitochondrial or not.