Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-2474: Remove reads from MT genes in Tagsort metrics #100

Merged
merged 45 commits into from
Feb 7, 2024
Merged

Conversation

aawdeh
Copy link
Contributor

@aawdeh aawdeh commented Jan 11, 2024

Remove reads on MT genes from the intronic, exonic, and intergenic counts in Optimus/Multiome. To do this, we did the following:

  1. Added the protected variables std::unordered_set<std::string> mito_genes_ to the class MetricGatherer. mito_genes_ are a set of MT genes

  2. Added the following additional input parameters to theMetricGatherer class: TagOrder tag_order, std::string gtf_file, std::string mitochondrial_gene_names_filename.

  3. Added function isMitochondrial to the class MetricGatherer which returns whether or not a gene is mitochondrial based on the tag_order.

  4. Moved function getInterestingMitochondrialGenes in the MetricGatherer constructor.

  5. Function parseAlignedReadFields in the MetricGatherer class.

  • Added condition if mitochondrial (this calls isMitochondrial) to check if the gene is mitochondrial or not before counting the number of reads_mapped_uniquely_, reads_mapped_exonic_, reads_mapped_intronic_, reads_mapped_intronic_as_ and reads_mapped_multiple_.
  1. Function ingestLine in the CellMetricGatherer class.
  • Added condition if mitochondrial (this calls isMitochondrial) in if statement to check if gene is mitochondrial or not.

@aawdeh aawdeh requested a review from khajoue2 January 23, 2024 21:26
Copy link
Contributor

@ekiernan ekiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked good! Thank you for demoing. I think as long as the number of MT reads matches what is expected as discussed, this can be merged.

@aawdeh aawdeh merged commit 21e260b into develop Feb 7, 2024
20 of 21 checks passed
@aawdeh aawdeh deleted the aa-mt-tagsort branch February 7, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants