Lk pd 2736 doublets #136
Merged
Lk pd 2736 doublets #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rary_tso_doublets
…sion" This reverts commit 200d6a9.
|
This PR is for warp-tools docker v2.4.0 |
kevinpalis
approved these changes
Sep 24, 2024
khajoue2
approved these changes
Sep 30, 2024
| #gex_data.write(f"{input_id}.h5ad") | ||
|
|
||
| print("Reading library metrics") | ||
| library = pd.read_csv(library_csv, header=None) |
There was a problem hiding this comment.
pandas DataFrame handling can be improved here:
library = pd.read_csv(library_csv, header=None, index_col=0, squeeze=True)
There was a problem hiding this comment.
could not use squeeze as is
| percent_keeper = keeper_cells/estimated_cells | ||
| percent_usable = keeper_cells/expected_cells | ||
|
|
||
| # Updating library metrics |
There was a problem hiding this comment.
consider using pd.concat() instead of manual dictionary creation: library = pd.concat([library, new_metrics])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing new warp-tools docker with scikit learn and scanpy; custom doublet script for Multiome analysis