Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/collator large ranges #578

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Fix/collator large ranges #578

merged 5 commits into from
Feb 11, 2025

Conversation

drmick
Copy link
Member

@drmick drmick commented Jan 30, 2025

No description provided.

@drmick drmick force-pushed the fix/collator-large-ranges branch from dfff5ee to d3331d7 Compare January 30, 2025 14:00
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 9.32203% with 107 lines in your changes missing coverage. Please review.

Project coverage is 42.88%. Comparing base (43ecee3) to head (c1a993c).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...r/src/collator/messages_reader/internals_reader.rs 0.00% 40 Missing ⚠️
collator/src/internal_queue/queue.rs 0.00% 22 Missing ⚠️
collator/src/manager/mod.rs 0.00% 18 Missing ⚠️
collator/src/collator/messages_reader/mod.rs 0.00% 8 Missing ⚠️
collator/src/internal_queue/types.rs 56.25% 7 Missing ⚠️
collator/src/queue_adapter.rs 0.00% 6 Missing ⚠️
consensus/src/engine/mempool_config.rs 40.00% 0 Missing and 3 partials ⚠️
cli/src/cmd/tools/gen_zerostate.rs 0.00% 1 Missing ⚠️
collator/src/mempool/impls/std_impl.rs 0.00% 1 Missing ⚠️
consensus/src/effects/store.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
- Coverage   42.95%   42.88%   -0.08%     
==========================================
  Files         278      278              
  Lines       51817    51883      +66     
  Branches    51817    51883      +66     
==========================================
- Hits        22259    22248      -11     
- Misses      28396    28471      +75     
- Partials     1162     1164       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drmick drmick force-pushed the fix/collator-large-ranges branch 4 times, most recently from cdc3b03 to 5617a76 Compare February 3, 2025 18:44
@drmick drmick requested review from Rexagon and SmaGMan February 3, 2025 18:44
@drmick drmick marked this pull request as ready for review February 3, 2025 18:45
@drmick drmick force-pushed the fix/collator-large-ranges branch from 5617a76 to aa91151 Compare February 3, 2025 19:12
@drmick drmick force-pushed the fix/collator-large-ranges branch from aa91151 to 14a5ae4 Compare February 4, 2025 05:17
@drmick drmick force-pushed the fix/collator-large-ranges branch 6 times, most recently from 7a577bc to 1121e3c Compare February 8, 2025 06:47
@drmick drmick requested a review from SmaGMan February 8, 2025 06:47
@drmick drmick force-pushed the fix/collator-large-ranges branch from 1121e3c to 07dd245 Compare February 8, 2025 06:55
@Rexagon Rexagon force-pushed the fix/collator-large-ranges branch from c79c495 to 6de3b2c Compare February 10, 2025 14:09
@SmaGMan SmaGMan marked this pull request as draft February 10, 2025 19:50
@SmaGMan SmaGMan marked this pull request as ready for review February 11, 2025 11:28
@Rexagon Rexagon force-pushed the fix/collator-large-ranges branch from 6de3b2c to c1a993c Compare February 11, 2025 20:47
@Rexagon Rexagon enabled auto-merge February 11, 2025 20:47
@Rexagon Rexagon added this pull request to the merge queue Feb 11, 2025
Merged via the queue into master with commit c1a993c Feb 11, 2025
18 of 20 checks passed
@Rexagon Rexagon deleted the fix/collator-large-ranges branch February 11, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants