Merge pull request #19 from badawe/bugfix/more_issues

Bugfix/more issues
brunomikoski · Aug 2, 2020 · 6e0478e · 6e0478e
2 parents c517934 + 924462b
commit 6e0478e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/CHANGELOG.MD b/CHANGELOG.MD
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+
+## [1.1.6]
+## Changed
+ - Crash while changing to debug mode while having the Collection inspector open
+ - Fix static generation code writing the full class name as the static class name
+
 ## [1.1.5]
 ## Changed
  - Fix possible stackoverflow on PostProcessor
@@ -13,12 +19,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
  - Fixed Create Collection context menu using the selected folder as target for both scrips and scriptable objects
  - Fixed some warnings
  - Fixed weird pair next name issue
-
-
+
  ## Added
  - You can now set specific overwrite static files location on the `CollectionSettings` file
  - Settings are now displayed on the Collection itself rather than on the registry
- - 
 
 ## [1.1.4]
 ## Changed
@@ -77,6 +81,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
  - Add a setup wizzard for first time settings creation
 
+[1.1.6]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.1.6
 [1.1.5]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.1.5
 [1.1.4]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.1.4
 [1.1.3]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.1.3

diff --git a/Scripts/Editor/ScriptableObjectCollectionCustomEditor.cs b/Scripts/Editor/ScriptableObjectCollectionCustomEditor.cs
@@ -42,7 +42,6 @@ private void OnDisable()
             }
 
             ObjectUtility.SetDirty(collection);
-            AssetDatabase.SaveAssets();
         }
 
         private void ValidateGUIDS()

diff --git a/Scripts/Editor/Utils/CodeGenerationUtility.cs b/Scripts/Editor/Utils/CodeGenerationUtility.cs
@@ -148,7 +148,7 @@ public static void GenerateStaticCollectionScript(ScriptableObjectCollection col
                 directives.AddRange(GetCollectionDirectives(collection));
 
                 AppendHeader(writer, ref indentation, nameSpace,
-                    collection.GetType().ToString(), true, false, directives.Distinct().ToArray());
+                    collection.GetType().Name, true, false, directives.Distinct().ToArray());
 
                 GeneratedStaticFileType staticFileTypeForCollection = ScriptableObjectCollectionSettings.Instance.GetStaticFileTypeForCollection(collection);
                 if (staticFileTypeForCollection == GeneratedStaticFileType.DirectAccess)

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "com.brunomikoski.scriptableobjectcollection",
   "displayName": "Scriptable Object Collection",
-  "version": "1.1.5",
+  "version": "1.1.6",
   "unity": "2018.4",
   "description": "Scriptable Object Collection",
   "keywords": [
-Original file line number
+Diff line change
@@ Expand Up / @@ -42,7 +42,6 @@ private void OnDisable() @@
                 }
                 ObjectUtility.SetDirty(collection);
-                AssetDatabase.SaveAssets();
             }
             private void ValidateGUIDS()
@@ Expand Down @@