This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix canonize function and enhance index semantics
#8
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8db7c33
Fix rightindex and leftindex logic
jofrevalles 55be446
Fix canonize! function and enhance syntax
jofrevalles 193e95f
Fix typo and add tests
jofrevalles d6eb2d0
Enhance tests
jofrevalles f8fa5e0
Update code for Periodic boundary
jofrevalles df93790
Fix leftsite and rightsite function
jofrevalles fa4bfbb
Add Site testset
jofrevalles 656e4d5
Update syntax
jofrevalles File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we canonize a periodic MPS? If so, doing a
::Union{Open,Periodic}is probably not the best solution.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, but we need to include the proper logic on the
canonizefunction. Nevertheless, we can always doleftsiteandrightsiteofPeriodicMPS.However, maybe it would be a good idea to put here a check so we don't go to the left of the
Site(1), in the case ofOpenMPS.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to do 2 separa methods:
leftsite(::Open)as it is nowleftsite(::Periodic)that wraps theiwith the periodThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, but we should check whether
siteis in range for thePeriodiccase.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not necessary, right? In
Periodicwe can assumeSite(4)is effectivelySite(1), for a periodic cell of3sites.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do that, but we have to stick to it then.