Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ITensors compat to 0.7 #297

Closed
wants to merge 2 commits into from
Closed

Conversation

starsfordummies
Copy link
Contributor

No description provided.

Copy link
Member

@mofeing mofeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing tests are not due to this PR, and ITensors/ITensorNetworks tests pass so i'm merging it

thanks @starsfordummies!

@mofeing
Copy link
Member

mofeing commented Jan 20, 2025

ah wait, it doesn't use ITensors 0.7... it seems like it's holded back by some other dependency

@starsfordummies do you mind running the following commands in a Julia session and showing me the result?

]activate test
]up
]st --outdated

i think it's getting holded back because of ITensorNetworks.jl, but not sure

@starsfordummies
Copy link
Contributor Author

mm I don't know, if I activate my Tenet env and add by hand ITensors, ITensorNetworks etc I seem to be able to install them

(Tenet) pkg> st
Project Tenet v0.8.0-DEV
Status `~/.julia/dev/Tenet/Project.toml`
  [1520ce14] AbstractTrees v0.4.5
  [d089a002] BijectiveDicts v0.2.1
  [861a8166] Combinatorics v1.0.2
  [34da2185] Compat v4.16.0
  [10b0fc19] DeltaArrays v0.1.1
  [b1794770] EinExprs v0.6.7
  [86223c79] Graphs v1.12.0
  [0d1a4710] ITensorMPS v0.3.4   
  [2919e153] ITensorNetworks v0.11.24
  [9136182c] ITensors v0.7.11
  [ebe7aa44] OMEinsum v0.8.4
  [7e506255] ScopedValues v1.3.0
  [37e2e46d] LinearAlgebra v1.11.0
  [9a3f8284] Random v1.11.0
  [9e88b42a] Serialization v1.11.0
  [2f01184e] SparseArrays v1.11.0
  [cf7118a7] UUIDs v1.11.0

@mofeing
Copy link
Member

mofeing commented Jan 20, 2025

yeah, but try doing it in the test environment together with st --outdated so we know which package is holding ITensors from being updated

@starsfordummies
Copy link
Contributor Author

(test) pkg> st --outdated
Status `~/.julia/dev/Tenet/test/Project.toml`
⌃ [13f3f980] CairoMakie v0.12.18 (<v0.13.1)
⌃ [1ecd5474] GraphMakie v0.5.12 (<v0.5.13)
⌅ [0b1a1467] KrylovKit v0.8.3 (<v0.9.0): ITensorMPS, ITensorNetworks
⌅ [ee78f7c6] Makie v0.21.18 (<v0.22.1): CairoMakie, GraphMakie
⌃ [418bc28f] YaoBlocks v0.13.9 (<v0.13.13)

(test) pkg> st
Status `~/.julia/dev/Tenet/test/Project.toml`
  [79e6a3ab] Adapt v4.1.1
  [4c88cf16] Aqua v0.8.9
  [d089a002] BijectiveDicts v0.2.1
  [8e7c35d0] BlockArrays v1.3.0
⌃ [13f3f980] CairoMakie v0.12.18
  [d360d2e6] ChainRulesCore v1.25.1
  [cdddcdb0] ChainRulesTestUtils v1.13.0
  [992eb4ea] CondaPkg v0.2.24
  [d58978e5] Dagger v0.18.14
  [10b0fc19] DeltaArrays v0.1.1
⌃ [1ecd5474] GraphMakie v0.5.12
  [86223c79] Graphs v1.12.0
  [2919e153] ITensorNetworks v0.11.24
  [9136182c] ITensors v0.7.11
⌅ [0b1a1467] KrylovKit v0.8.3
⌅ [ee78f7c6] Makie v0.21.18
  [46757867] NetworkLayout v0.4.9
  [ebe7aa44] OMEinsum v0.8.4
  [2ae35dd2] Permutations v0.4.22
  [6099a3de] PythonCall v0.9.23
  [b9105292] Quac v0.3.5
  [3c362404] Reactant v0.2.19
  [85d41934] Tenet v0.8.0-DEV `..`
  [5872b779] Yao v0.9.0
⌃ [418bc28f] YaoBlocks v0.13.9
  [8ba89e20] Distributed v1.11.0
  [37e2e46d] LinearAlgebra v1.11.0
  [44cfe95a] Pkg v1.11.0
  [9a3f8284] Random v1.11.0
  [9e88b42a] Serialization v1.11.0
  [8dfed614] Test v1.11.0
  [cf7118a7] UUIDs v1.11.0
Info Packages marked with ⌃ and ⌅ have new versions available. Those with ⌃ may be upgradable, but those with ⌅ are restricted by compatibility constraints from upgrading. To see why use `status --outdated`

¯_(ツ)_/¯

@mofeing
Copy link
Member

mofeing commented Feb 3, 2025

@starsfordummies I've fixed the CompatHelper workflow and it correctly updated the compat bound of ITensors.

@mofeing mofeing closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants