Move to a interface system #314
Draft
+245
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofeing
force-pushed
the
refactor/forget-inheritance-move-to-traits
branch
from
449b006 to
ea84402
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is to stop relying on the
AbstractTensorNetwork,AbstractQuantumandAbstractAnsatzabstract inheritance system and move to a duck typing system.Since duck typing cannot be enforced, the way Julia deals with this is by formalizing the interface on the documentation (which you can find in https://bsc-quantic.github.io/Tenet.jl/previews/PR314/manual/interfaces) and testing the interface (which was added on #312).
changes
Quantumgets renamed toPluggableand is abstracted to just an interface (no implementation)Ansatz(i.e. mapping betweenLaneandTensor) are abstracted to aAnsatzinterface (no implementation)Ansatz(which fulfills both the newPluggableandAnsatzinterfaces) get renamed toQuantumquestions
contractandcontract!required methods for the interface?