Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified to columns in the order of the selected column list #147

Conversation

miyamo2
Copy link
Contributor

@miyamo2 miyamo2 commented Mar 18, 2024

This PR modifies ResultResultSet.Columns to be in the order of the selected column list.
However, when SELECT * FROM... or returnsvalue will be sorted by column name as usual.

Issue #146

@miyamo2 miyamo2 changed the title Modified to columns in the order of the selected column list #146 Modified to columns in the order of the selected column list Mar 18, 2024
@miyamo2 miyamo2 changed the title #146 Modified to columns in the order of the selected column list Issue#146 Modified to columns in the order of the selected column list Mar 18, 2024
@miyamo2 miyamo2 changed the title Issue#146 Modified to columns in the order of the selected column list Modified to columns in the order of the selected column list Mar 18, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.80%. Comparing base (2d1cd17) to head (b3f73ca).
Report is 4 commits behind head on main.

Files Patch % Lines
stmt_document.go 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   84.73%   84.80%   +0.06%     
==========================================
  Files           9        9              
  Lines        1173     1191      +18     
==========================================
+ Hits          994     1010      +16     
- Misses        126      127       +1     
- Partials       53       54       +1     
Flag Coverage Δ
other 79.93% <89.47%> (+0.13%) ⬆️
parsing 23.92% <0.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@btnguyen2k btnguyen2k merged commit 208ba42 into btnguyen2k:main Mar 21, 2024
47 of 49 checks passed
@miyamo2 miyamo2 deleted the feat/sort-columns-in-order-of-selection-list branch July 13, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants