Merge pull request #195 from buildkite/toote_rubocop_and_dependabot

Rubocop and dependabot
buildkite · Feb 16, 2025 · 380cdc3 · 380cdc3
2 parents 80e3123 + bd0bcbe
commit 380cdc3
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 11 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -3,8 +3,8 @@ updates:
   - package-ecosystem: "bundler"
     directory: '/app'
     schedule:
-      interval: 'daily'
+      interval: 'weekly'
   - package-ecosystem: "docker"
     directory: "/"
     schedule:
-      interval: daily
+      interval: weekly
diff --git a/app/Gemfile.lock b/app/Gemfile.lock
@@ -3,12 +3,13 @@ GEM
   specs:
     ast (2.4.2)
     awesome_print (1.9.2)
-    diff-lcs (1.5.1)
-    json (2.9.1)
+    diff-lcs (1.6.0)
+    json (2.10.1)
     language_server-protocol (3.17.0.4)
+    lint_roller (1.1.0)
     nio4r (2.7.4)
     parallel (1.26.3)
-    parser (3.3.7.0)
+    parser (3.3.7.1)
       ast (~> 2.4.1)
       racc
     parslet (2.0.0)
@@ -23,7 +24,7 @@ GEM
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.2)
+    rspec-core (3.13.3)
       rspec-support (~> 3.13.0)
     rspec-expectations (3.13.3)
       diff-lcs (>= 1.2.0, < 2.0)
@@ -35,9 +36,10 @@ GEM
       awesome_print (> 1.0.0)
       rspec (> 3.0.0)
     rspec-support (3.13.2)
-    rubocop (1.71.2)
+    rubocop (1.72.0)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)

diff --git a/app/lib/bk/compat/models/plugin.rb b/app/lib/bk/compat/models/plugin.rb
@@ -7,7 +7,7 @@ module Compat
       'docker-compose' => 'v5.0.0',
       'docker-login' => 'v3.0.0',
       'ecr' => 'v2.7.0'
-    }.to_h do |p, v|
+    }.each do |p, v|
       env_friendly = p.upcase.tr('^A-Z0-9', '_')
       [p, ENV.fetch("BUILDKITE_PLUGIN_#{env_friendly}_VERSION", v)]
     end.freeze

diff --git a/app/lib/bk/compat/server.rb b/app/lib/bk/compat/server.rb
@@ -21,10 +21,10 @@ def call(env)
         end
       end
 
-      private
-
       INDEX_HTML_PATH = File.expand_path(File.join(__FILE__, '..', '..', '..', '..', 'public', 'index.html'))
 
+      private
+
       def handle_index(_req)
         # Read once in production mode, otherwise - read each time.
         html = if ENV['RACK_ENV'] == 'production'