Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Type::write return correct value for rumqttd #819

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

amokfa
Copy link
Contributor

@amokfa amokfa commented Mar 12, 2024

Type of change

write method wasn't returning the number of bytes read correctly for some types in rumqttd.

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

@coveralls
Copy link

coveralls commented Mar 12, 2024

Pull Request Test Coverage Report for Build 8243325619

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 37.83%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rumqttd/src/protocol/v4/connect.rs 0 1 0.0%
rumqttd/src/protocol/v5/connect.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 8233430325: 0.003%
Covered Lines: 6254
Relevant Lines: 16532

💛 - Coveralls

Copy link
Member

@swanandx swanandx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :) 🚀

@swanandx swanandx merged commit bfc9f9a into main Mar 12, 2024
4 checks passed
@swanandx swanandx deleted the fix_rumqttd_write_return_value branch March 12, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants