Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter unexpected PubAck in event loop pending queue. #859

Merged
merged 8 commits into from
May 22, 2024
Merged

fix: filter unexpected PubAck in event loop pending queue. #859

merged 8 commits into from
May 22, 2024

Conversation

wangwen-4220
Copy link
Contributor

@wangwen-4220 wangwen-4220 commented May 7, 2024 •
edited by de-sh
Loading

Type of change

bug fix: #849
An isolated PUBACK packet is being sent to the broker after the client reconnects.

@wangwen-4220
Update eventloop.rs
79135ba 
filter unexpected puback.
@wangwen-4220
Update eventloop.rs
b6fa2d9 
filter unexpected puback
@wangwen-4220
cargo fmt
39ee367
@wangwen-4220 wangwen-4220 mentioned this pull request May 7, 2024
Closed
de-sh
de-sh reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@de-sh de-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry in rumqttc/CHANGELOG.md that mentions this as a fix, thanks!

wangwen-4220 and others added 3 commits May 13, 2024 16:57
@wangwen-4220
Update CHANGELOG.md
08ad938 
update CHANGELOG.md
@wangwen-4220 @de-sh
Update rumqttc/src/eventloop.rs
ad4e4b4 
apply suggestion from rumqtt team

Co-authored-by: Devdutt Shenoi <devdutt@outlook.in>
@wangwen-4220 @de-sh
Update rumqttc/src/v5/eventloop.rs
721b2c5 
apply suggestion from rumqtt team

Co-authored-by: Devdutt Shenoi <devdutt@outlook.in>
@wangwen-4220
Copy link
Contributor Author

Please add an entry in rumqttc/CHANGELOG.md that mentions this as a fix, thanks!

Thanks for suggestion. Updated, please have a PR review.

de-sh
de-sh approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@de-sh de-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9078199207

Details

  • 7 of 16 (43.75%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 36.532%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rumqttc/src/eventloop.rs 7 8 87.5%
rumqttc/src/v5/eventloop.rs 0 8 0.0%
Totals Coverage Status
Change from base Build 9035769889: 0.006%
Covered Lines: 5989
Relevant Lines: 16394
💛 - Coveralls

@de-sh de-sh merged commit 51224e1 into bytebeamio:main May 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de-sh de-sh de-sh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected PUBACK Packet Sent to Reconnected Broker
3 participants
@wangwen-4220 @coveralls @de-sh