Adding delaystart a new workflow with 30 sec delay #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add description to the pr introducing the changes you made |
ibarrajo
reviewed
Jan 27, 2025
vishwa-uber
changed the title
cmd/samples/README.md
Outdated
| make <WORKFLOW NAME> | ||
|
|
||
| Example: | ||
| make delaystart |
There was a problem hiding this comment.
nit: I'd avoid adding an extra example here. make helloworld seems sufficient to show how to build an individual workflow
| @@ -0,0 +1,159 @@ | |||
| [ | |||
taylanisikdemir
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: one customer was complaining about delay start didn't work.
But in CDNC-12162 we've had enough proof that it worked.
We don't have a delayed start workflow sample, need to have one.
The simple way to do it is to use the hello world workflow as a template to create a new workflow. Need to:
copy and paste the entire hello world workflow
change the workflow name so that it won't conflict with helloworld workflow
add a delay start option in workflowOptions
update the readme about how to run the new workflow
One example of delay start option can be added in here. In the attached picture it also shows how to add the option.
DelayStart: time.Minute * 5,