Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for DSL workflow #87

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vishwa-uber
Copy link
Contributor

No description provided.

@davidporter-id-au
Copy link
Member

do you mind adding a description for the diff?

env.RegisterActivityWithOptions(sampleActivity, activity.RegisterOptions{
Name: "sampleActivity",
})
env.ExecuteWorkflow(func(ctx workflow.Context) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to keep up, I think this is basically creating an inline simple workflow, I guess for the intention of testing the different parts of the DSL example

Was this your intention to create a mini-workflow in this callback? I might need to zoom briefly to just understand the intent.

This is fine from a code perspective and it increases coverage, but I'm just not sure if its testing the intended code-path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants