Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve detection of Go projects #317

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve detection of Go projects #317

wants to merge 2 commits into from

Conversation

FallenWarrior2k
Copy link

By checking for the files used by the go mod and dep tools, this should noticeably improve the detection of Go projects.

@FallenWarrior2k
Go: Reorder checks to not unnecessarily glob
0d554a8 
This prevents unnecessarily generating a lot of file names when in a
directory with lots of Go files that satisfy one of the other checks.
@FallenWarrior2k
Go: Add detection support for go mod and dep
19447c5
@FallenWarrior2k FallenWarrior2k mentioned this pull request Mar 17, 2021
Open
@134130
Copy link

134130 commented May 29, 2024

@caiogondim Can you approve this PR?

In some go projects, there is no *.go files on the root of project but go.mod file. Because the main.go files are collected in /cmd/**/main.go and the libraries are in /pkg/**/*.go

So currently, the prompt_go is not working on some go projects.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FallenWarrior2k @134130