Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C01-device-errors.feature #386

Merged

Conversation

jlurien
Copy link
Contributor

@jlurien jlurien commented Jan 20, 2025

What type of PR is this?

  • correction
  • tests

What this PR does / why we need it:

One scenario was incomplete, as explained in the issue

Which issue(s) this PR fixes:

Fixes #385

Does this PR introduce a breaking change?

  • Yes
  • No

@jlurien
Copy link
Contributor Author

jlurien commented Jan 20, 2025

As reported by @bigludo7 in camaraproject/DeviceLocation#281 (comment)

PedroDiez
PedroDiez previously approved these changes Jan 20, 2025
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rartych
rartych previously approved these changes Jan 21, 2025
Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych added correction correction in documentation Spring25 labels Jan 21, 2025
@jlurien jlurien dismissed stale reviews from rartych and PedroDiez via a22d47c January 21, 2025 14:34
@jlurien jlurien requested review from rartych and PedroDiez January 21, 2025 14:35
PedroDiez
PedroDiez previously approved these changes Jan 21, 2025
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trailing spaces and multiple empty lines removed
Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces and multiple empty lines removed to avoid Gherkin linting errors

Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych merged commit 20f3a7b into camaraproject:main Jan 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction correction in documentation Spring25
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix test for device UNSUPPORTED_IDENTIFIER
3 participants