Remove sinkCredential from Subscription schema in event-subscription-template.yaml

[eric-murray]

What type of PR is this?

• correction

What this PR does / why we need it:

Remove sinkCredential from Subscription schema in event-subscription-template.yaml as it cannot be used

Which issue(s) this PR fixes:

Fixes #399

Does this PR introduce a breaking change?

• Yes
• No

Note: anyone who was returning sink credentials in responses might complain this breaks their implementation, but they should not have been doing that anyway

Special notes for reviewers:

None

Changelog input

 release-note
 - Remove sinkCredential from Subscription schema in event-subscription-template.yaml

Additional documentation

None

[patrice-conil]

LGTM

[PedroDiez]

LGTM, just editorial comment in Line 14,
version: 0.2.0-rc.1

as we have already reached r2.2
https://github.com/camaraproject/Commonalities/blob/r2.2/artifacts/camara-cloudevents/event-subscription-template.yaml#L14

[eric-murray]

LGTM, just editorial comment in Line 14, version: 0.2.0-rc.1

as we have already reached r2.2

This PR won't affect the file version - it is picking that up from the main branch. The usual approach after a (pre-)release is for the person doing the release to immediately raise a new PR to reset all version numbers back to WIP. Once the version number is reset, this PR can be merged and all will be well.

[PedroDiez]

LGTM

[rartych]

LGTM