Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errormessage for unsupported device identifieres #261

Conversation

maxl2287
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Fixing a typo / mistake in the error for GENERIC_422_UNSUPPORTED_DEVICE_IDENTIFIERS

Which issue(s) this PR fixes:

Fixes #260

bigludo7
bigludo7 previously approved these changes Sep 27, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
From a process perspective does it means that we have to do a new release @jlurien ?

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For any change in the specs in the main branch we have to set versions to wip again

@jlurien
Copy link
Collaborator

jlurien commented Sep 27, 2024

LGTM From a process perspective does it means that we have to do a new release @jlurien ?

We have to decide if changes are worthy for a new release. I would wait until we have something really relevant, and in that case update all small things as well

@maxl2287
Copy link
Contributor Author

maxl2287 commented Oct 9, 2024

@jlurien & @bigludo7 I updated the version to "wip".
I guess we can then integrate it into the main, right? (if you are okay with it)

jlurien
jlurien previously approved these changes Oct 21, 2024
@jlurien
Copy link
Collaborator

jlurien commented Nov 18, 2024

@jlurien & @bigludo7 I updated the version to "wip". I guess we can then integrate it into the main, right? (if you are okay with it)

I noticed that you have to update as well the servers url to /vwip

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlurien jlurien merged commit c300186 into camaraproject:main Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small typo in GENERIC_422_UNSUPPORTED_DEVICE_IDENTIFIERS - example
4 participants