-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[location-verification / geofencing]: decrease radius minimum to "1" for circle-area #285
[location-verification / geofencing]: decrease radius minimum to "1" for circle-area #285
Conversation
…d an HTTP-422 if the area cannot be covered by the implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but hope we'll have some collision with #281 for location-verification.
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
waiting for @jlurien and @javier-carrocalabor if this could be part of Spring25 Meta Release |
Checked the potential privacy issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Having reviewed this from an aggregator and customer developer perspective there are some things that we should discuss and define.
2. Interpreting Error Messages |
I totally understand your concerns, @james-emerson, and agree we should be able to provide better understanding to the users of the API. I think that removing the 2km minimum value is a big progress, as all of us, CSPs and users of the APIs, were missing use cases that were feasible. Now those use cases are at reach, but they are not easy to manage, especially thinking in cross-CSPs compatibility (network deployments may differ among CSPs, or different technical restrictions may apply to CSPs in the same zones).
|
In the current proposal, it is: LOCATION_VERIFICATION.AREA_NOT_COVERED: The location is not supported -> This means for example that input area is out of the operator coverage (e.g. another country, ocean, etc) LOCATION_VERIFICATION.INVALID_AREA: The area is too small, the polygon is too complex, etc -> This would be the error in case of the input area is too small to be accepted (for legal or implementation reasons) |
@maxl2287 To clarify the usage of these errors we may update in location verification, the following text in line #9: API consumers are able to verify whether the location of certain user device is within the area specified. Currently the only area supported as input is a circle determined by a set of coordinates (latitude and longitude) and some expected accuracy (radius).
fyi @james-emerson @javier-carrocalabor. Please suggest any enhancements. |
…mum-of-area-circle # Conflicts: # code/API_definitions/location-verification.yaml
… is not coverable or invalid
…nimum-of-area-circle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@javier-carrocalabor Thanks for your feedback to address my 1. Developer Guidance on Input Radius There is enough information for us to move forward with producing developer guidance for this release and we may revisit in future. @maxl2287 Regarding my 2. Interpreting Error Messages I only have one concern with your proposal that is where it says "or implementation issues". This feels like a catch-all that does not relate to privacy or regulatory issues. Can this be more specific or put this under another error message? |
Hi @james-emerson, I proposed this text. Adding "or implementation issues" tries to cover any constraint on the operator side (not necessarily regulatory pr privacy-related), that causes the implementation to reject the input area as invalid for the operator. The message can always give more detailed information. We may use another wording, or remove that part, but I wouldn't split codes for INVALID_AREA. wdyt @javier-carrocalabor ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR decreses the minimum of a circle-area radius to "1".
The provider of the API can restrict then the minimum and respond with HTTP-422 if the size of the area is to small and cannot be covered.
Which issue(s) this PR fixes:
Fixes #282
Special notes for reviewers:
Changelog input