EAM API: fixes for app instance post (alternative to #316) #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Note that this is an alternative approach to #316 which attempted to address the same issues but using a singular API approach. This PR is the bulk API approach which more closely resembles the original intent of the API.
Which issue(s) this PR fixes:
Fixes #256, #255
Special notes for reviewers:
One potential contentious change I have made is to include the AppId with each AppInstanceDeployRequest, rather than make it common across all requests. The primary reason was to generalize the handling of "bulk" APIs, such that a bulk API simply has request/response objects which are arrays of what the singular API would be. This approach could be extended to other APIs (although I don't really see any candidates at the moment). This also makes it more flexible, allowing a user to deploy different AppIds across various edge-sites in a single API call, given that the intent here is to avoid the overhead of making multiple API calls to deploy app instances.
Changelog input
Additional documentation