-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process applications feature #4762
base: develop
Are you sure you want to change the base?
Conversation
@@ -1136,8 +1134,7 @@ export class App extends PureComponent { | |||
if ( | |||
activeTab !== prevState.activeTab || | |||
tabs !== prevState.tabs || | |||
layout !== prevState.layout || | |||
endpoints !== prevState.endpoints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be used (again) once we support "endpoints" for deployment.
Why would we remove it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Of course fine, if we consider to store the endpoints in a different place, once supported).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it because it's not used at all at the moment and was probably meant to be removed. I would rather reintroduce it again in the context of adding a feature that requires it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just have to be aware that this is "the data model" that was previously used. We can remove it, but then we'll not remember the data model once we re-introduce an endpoints feature.
@philippfromme Please add "steps to try out" to this PR, so @lmbateman and others can give it a run (to understand the UX we propose). |
5350340
to
cbc64dc
Compare
cbc64dc
to
3c7d415
Compare
You mean Close process application would close all files belonging to the open process application? Interesting idea I haven't thought about. 🤔 |
Exactly. 😊 |
When I try to deploy a file from a process application, the modeler just reloads. Same thing happens when I save a file. Both only happens to files in a process application, the rest works normally. Screen.Recording.2025-01-15.at.11.56.30.mov |
This happens becasue the modeler reloads when something in |
I've added the |
70f0555
to
1653967
Compare
This comment was marked as resolved.
This comment was marked as resolved.
I'll try to help with this one. |
This comment was marked as resolved.
This comment was marked as resolved.
@philippfromme were you able to run a local build of this? So the one from On my machine, the build job results in the source code of To verify the build, besides running the app, you can execute this command for MacOS: |
Creating a variable on any task in BPMN model with Variables panel open (or opening it after) crashes. Screen.Recording.2025-01-15.at.17.36.50.mov |
Also, we assume that a form json contains |
^ - these are small changes |
Tests pending... |
cb030fb
to
6517a80
Compare
Symlink issue can only be partially resolved with configuration. Even with |
6517a80
to
6ee48b8
Compare
6ee48b8
to
52a094e
Compare
52a094e
to
71c247a
Compare
71c247a
to
63b099c
Compare
63b099c
to
13dfaf6
Compare
OK somehow it's good now o.O |
A form always has an ID by default and you cannot remove it through the properties panel. If we want to account for cases that cannot be modeled we should also account for processes and decisions with no ID and add the same error handling to the BPMN and DMN processor. 🤔 try {
const form = JSON.parse(item.file.contents); // if the form is null
formId = form.id; // then this will throw
assert(formId, 'Form must have an id'); // else this assumes that the form is not null but has no ID which cannot be modeled
} catch (error) {
return {
type: 'form',
error: error.message,
ids: []
};
} |
With the new RPA tab merged in the meantime should we add these as recognized process application items? |
Perhaps only if RPA is enabled with the flag? |
Eventually, yes. But it's also OK to add the support later, when we understand the story of RPA linking. AFAIK it was done via element templates so far which indicates that we may be missing something (@marstamm correct me if I'm wrong). |
Proposed Changes
Backend
file-context
feature.bpmn
,.dmn
,.form
,.process-application
)Frontend
ProcessApplications
feature to open and close process applications automatically✨ New application menu entry
.process-application
file will be created✨ New (➕) entry
✨ New button in status bar
✨ New overlay
✨ Tab groups
Try it out
I've added an example process application: a354d21
Open any file in this directory to see the process application.
To run the Camunda Modeler try
npm install && npm start
Follow-ups
References
feature to get reference from and to resourcesAutoCompletions
feature to get autocompletionsCloses #4666
Closes #4675
Closes #4687
Related to #4676
Related to #4664
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}