Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply uncontroversial ruff format changes #459

Closed
wants to merge 1 commit into from

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Feb 27, 2025

Black and ruff format disagree how to format some multi-line Python code, but ruff is more aggressive in unwrapping lines. So apply the uncontroversial ruff format changes:

ruff format
black -C .

Black and `ruff format` disagree how to format some multi-line Python
code, but ruff is more aggressive in unwrapping lines. So apply the
uncontroversial ruff format changes:

```
ruff format
black -C .
```
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.60%. Comparing base (e18ec92) to head (27cfe6b).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
apport/hookutils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   83.60%   83.60%           
=======================================
  Files         101      101           
  Lines       20451    20451           
  Branches     3219     3219           
=======================================
  Hits        17098    17098           
  Misses       2858     2858           
  Partials      495      495           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdrung
Copy link
Collaborator Author

bdrung commented Feb 27, 2025

IMO codecov/patch can be ignored here since it failed to detect all modified lines.

@bdrung bdrung requested a review from schopin-pro February 27, 2025 15:40
Copy link
Contributor

@schopin-pro schopin-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK, we pick one set of rules enforced by ONE TOOL and we stick with it. If you want to add to those rules in your own commits go for it, but don't enforce it globally unless you have (full) automation to back it up.

@bdrung
Copy link
Collaborator Author

bdrung commented Feb 28, 2025

Then let's wait for ruff format and black to not disagree.

@bdrung bdrung closed this Feb 28, 2025
@bdrung bdrung deleted the ruff-format branch February 28, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants