problem_report: reduce chunk size from 1 MB to 128 kB #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
=======================================
Coverage 83.61% 83.61%
=======================================
Files 101 101
Lines 20464 20464
Branches 3219 3219
=======================================
Hits 17111 17111
Misses 2858 2858
Partials 495 495 ☔ View full report in Codecov by Sentry. |
Use a consistant chunk size of 128 kB (instead of 1 MB) which is also the maximum block size of Zstandard (`ZSTD_BLOCKSIZE_MAX`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a consistant chunk size of 128 kB (instead of 1 MB) which is also the maximum block size of Zstandard (
ZSTD_BLOCKSIZE_MAX).