test: replace assertTrue by more specific assert checks #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of failures `TestCase.assertTrue` will only tell that the value is not True. Replace `assertTrue` by `assertEqual` or `assertIn` to get better failure messages. Following snippet was used to find the instances: ``` git grep assertTrue | grep == ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
=======================================
Coverage 83.61% 83.61%
=======================================
Files 101 101
Lines 20464 20465 +1
Branches 3219 3219
=======================================
+ Hits 17111 17112 +1
+ Misses 2858 2857 -1
- Partials 495 496 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of failures
TestCase.assertTruewill only tell that the value is not True. ReplaceassertTruebyassertEqualorassertInto get better failure messages. Following snippet was used to find the instances: