feat(vmware): Support network events

[akutz]

Proposed Commit Message

feat(vmware): Support network events

This patch updates the DataSource for VMware to support network
reconfiguration when the BOOT, BOOT_LEGACY, BOOT_NEW_INSTANCE,
and HOTPLUG events are received.

Previously the datasource could only reconfigure the network if
a new instance ID was detected. However, due to features like
backup/restore, migrating VMs, etc., it was determined that it is
valuable to support reconfiguring the network without changing the
instance ID. This is because changing the instance ID also means
running the per-instance configuration modules, such as regenerating
the system's SSH host keys, which could lock out automation.

This patch also indicates the datasource supports network reconfig
for HOTPLUG events, such as when a new NIC is added to a VM. Please
note that HOTPLUG is only supported when the transport type is not
IMC.

Additional Context

NA

Test Steps

$ make clean_pyc && PYTHONPATH="$(pwd)" python3 -m pytest -v tests/unittests/sources/test_vmware.py >/dev/null 2>&1 && echo "success"
success

Merge type

• Squash merge using "Proposed Commit Message"
• Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Fixes #5729

[akutz]

cc @PengpengSun

[PengpengSun]

Hi @akutz
I think this will address this cloud-init issue #5729, we are good when transport is guestinfo, metadata can be updated before HotPlug. But with imc transport, I need figure out how HotPlug work with live customization, usually a hardware change is before guest customization.

[akutz]

Hi @akutz I think this will address this cloud-init issue #5729, we are good when transport is guestinfo, metadata can be updated before HotPlug. But with imc transport, I need figure out how HotPlug work with live customization, usually a hardware change is before guest customization.

Do you think I should remove HOTPLUG if the transport is IMC then?

[akutz]

Hi @akutz I think this will address this cloud-init issue #5729, we are good when transport is guestinfo, metadata can be updated before HotPlug. But with imc transport, I need figure out how HotPlug work with live customization, usually a hardware change is before guest customization.

Do you think I should remove HOTPLUG if the transport is IMC then?

@PengpengSun I updated the PR so that HOTPLUG is only supported if the datasource is not using the IMC transport.