feat: add HAProxy TLS Termination #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattrees
force-pushed
the
tls-termination-haproxy
branch
from
003da84 to
485744c
Compare
SK1Y101
reviewed
Jul 1, 2024
skatsaounis
requested changes
Jul 1, 2024
There was a problem hiding this comment.
I added some inline comments for you to take a look. Overall, the PR looks good. Thank you @wyattrees 🙂 .
One last need: We need to also add a README file that describes how we can enable TLS termination with Anvil. Could you please prepare a doc like this and add it to your PR? Thank you.
wyattrees
force-pushed
the
tls-termination-haproxy
branch
5 times, most recently
from
d29fe84 to
f06bc1e
Compare
skatsaounis
requested changes
Jul 10, 2024
skatsaounis
requested changes
Jul 11, 2024
wyattrees
force-pushed
the
tls-termination-haproxy
branch
from
c4b9b4e to
0c4a998
Compare
skatsaounis
force-pushed
the
tls-termination-haproxy
branch
2 times, most recently
from
6a18a2c to
32abfbd
Compare
wyattrees
force-pushed
the
tls-termination-haproxy
branch
2 times, most recently
from
fba4856 to
3583fbb
Compare
wyattrees
force-pushed
the
tls-termination-haproxy
branch
from
81d71de to
1dc7569
Compare
|
@skatsaounis this is ready for review once again. canonical/maas-charms#194 still needs to be merged & released, but you can test with the |
…es. Set tls config via settings yaml crts directory. Add instructions for TLS termination to README
…t/region communication
…, add acl for access to port 80
…fying cert/key files
…it's end. Change agent-service to agent_service to comply with underscore convention
wyattrees
force-pushed
the
tls-termination-haproxy
branch
from
7edc7ac to
1bc9522
Compare
|
Enabler for #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asks user for an SSL certificate and key for TLS termination at HA Proxy.