Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: read manifest from stdin #60

Merged
merged 1 commit into from
Sep 2, 2024
Merged

feat: read manifest from stdin #60

merged 1 commit into from
Sep 2, 2024

Conversation

skatsaounis
Copy link
Collaborator

@skatsaounis skatsaounis commented Sep 1, 2024 •
edited
Loading

  • Accept stdin as manifest file by setting click.Path.allow_dash to True
  • open manifest file with click.open_file() which can handle dash appropriately
  • Implement maas-anvil version of AddManifestStep to use manifest_data
  • Update README
  • Fix typos

resolves: #55

@skatsaounis skatsaounis force-pushed the gh-55 branch 2 times, most recently from 5a9b8d6 to 2d73d72 Compare September 2, 2024 07:35
bjornt
bjornt approved these changes Sep 2, 2024
View reviewed changes
Copy link

@bjornt bjornt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@skatsaounis skatsaounis merged commit 1d1f97e into canonical:main Sep 2, 2024
5 checks passed
@skatsaounis skatsaounis deleted the gh-55 branch September 2, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornt bjornt bjornt approved these changes

@SK1Y101 SK1Y101 Awaiting requested review from SK1Y101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: consume manifest from stdin during bootstrap
2 participants
@skatsaounis @bjornt