feat: add support for TLS configuration at MAAS charm #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig-tls enable if tls_mode=passthrough
…iles. Ensure the files exist in the proper place before configuring TLS
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
skatsaounis
requested changes
Sep 6, 2024
…, as the types of these are checked on deployment
skatsaounis
requested changes
Oct 3, 2024
skatsaounis
requested changes
Oct 4, 2024
There was a problem hiding this comment.
On second thoughts: We need to run the configure TLS on config changed so I am going to remove the -1 until we got this fixed. The way it is right now it's not going to update the TLS when user decides to do it. We should also think if adding it only on config_changed is enough. On setup phase the config_changed event is triggered but MAAS is not initialized yet. So my feeling is that we need to add it there with a check on maas initialization plus to a place that follows the first maas_initialization. I hope it makes sense
…ng TLS. Check whether TLS is enabled before enabling/disabling it
…ed, use this to check for initialization
skatsaounis
requested changes
Nov 8, 2024
wyattrees
added a commit
to wyattrees/maas-charms
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit ddbc0fd)
skatsaounis
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds three config items:
ssl_cert_content,ssl_key_contentandssl_cacert_content, as well as a helper function to runmaas config-tls enable...