refactor: fix selector memoization warning (#5436)

canonical · May 17, 2024 · 527c03e · 527c03e
1 parent a58fbfd
commit 527c03e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/app/machines/views/MachineDetails/MachineConfiguration/TagForm/TagForm.tsx b/src/app/machines/views/MachineDetails/MachineConfiguration/TagForm/TagForm.tsx
@@ -21,7 +21,7 @@ const TagForm = ({ systemId }: Props): JSX.Element | null => {
     machineSelectors.getById(state, systemId)
   );
   const tags = useSelector((state: RootState) =>
-    tagSelectors.getByIDs(state, machine?.tags || [])
+    tagSelectors.getByIDs(state, machine?.tags || null)
   );
   const tagsLoading = useSelector(tagSelectors.loading);
   const taggingMachines = useSelector(machineSelectors.updatingTags);

diff --git a/src/app/store/subnet/selectors.ts b/src/app/store/subnet/selectors.ts
@@ -60,10 +60,10 @@ const active = createSelector(
 const getByIds = createSelector(
   [
     defaultSelectors.all,
-    (_state: RootState, ids: Subnet[SubnetMeta.PK][]) => ids,
+    (_state: RootState, ids: Subnet[SubnetMeta.PK][] | null) => ids,
   ],
-  (subnets, ids) => {
-    return subnets.filter(({ id }) => ids.includes(id));
+  (subnets, ids = []) => {
+    return subnets.filter(({ id }) => ids?.includes(id));
   }
 );
 

diff --git a/src/app/subnets/views/VLANDetails/DHCPStatus/DHCPStatus.tsx b/src/app/subnets/views/VLANDetails/DHCPStatus/DHCPStatus.tsx
@@ -64,7 +64,7 @@ const DHCPStatus = ({ id }: Props): JSX.Element | null => {
     vlanSelectors.getById(state, id)
   );
   const vlanSubnets = useSelector((state: RootState) =>
-    subnetSelectors.getByIds(state, vlan?.subnet_ids || [])
+    subnetSelectors.getByIds(state, vlan?.subnet_ids || null)
   );
   const subnetsLoading = useSelector(subnetSelectors.loading);