fix: DHCPTable, TagForm, VLANDetails selectors

- In VLANDetails.tsx, update the call to subnetSelectors.getByIds to pass null instead of an empty array when vlan?.subnet_ids is falsy.
- In TagForm.tsx, prevent the events array from being re-created on every render

Signed-off-by: Peter Makowski <me+git@petermakowski.io>

src/app/base/components/DHCPTable/DHCPTable.tsx

@@ -140,13 +140,11 @@ const DHCPTable = ({
 }: Props): JSX.Element | null => {
   const [expanded, setExpanded] = useState<DHCPSnippet["id"] | null>(null);
   const dhcpsnippetLoading = useSelector(dhcpsnippetSelectors.loading);
+  const subnetIds = subnets?.map(({ id }) => id) || null;
   const dhcpsnippets = useSelector((state: RootState) =>
     node
       ? dhcpsnippetSelectors.getByNode(state, node?.system_id)
-      : dhcpsnippetSelectors.getBySubnets(
-          state,
-          subnets?.map(({ id }) => id)
-        )
+      : dhcpsnippetSelectors.getBySubnets(state, subnetIds)
   );
 
   useFetchActions([dhcpsnippetActions.fetch]);

src/app/machines/views/MachineDetails/MachineConfiguration/TagForm/TagForm.tsx

@@ -25,11 +25,9 @@ const TagForm = ({ systemId }: Props): JSX.Element | null => {
   );
   const tagsLoading = useSelector(tagSelectors.loading);
   const taggingMachines = useSelector(machineSelectors.updatingTags);
+  const eventActions = [NodeActions.TAG, NodeActions.UNTAG];
   const errors = useSelector((state: RootState) =>
-    machineSelectors.eventErrorsForIds(state, systemId, [
-      NodeActions.TAG,
-      NodeActions.UNTAG,
-    ])
+    machineSelectors.eventErrorsForIds(state, systemId, eventActions)
   )[0]?.error;
   const canEdit = useCanEdit(machine, true);
 

src/app/subnets/views/VLANDetails/VLANDetails.tsx

@@ -37,7 +37,7 @@ const VLANDetails = (): JSX.Element => {
   );
   const vlansLoading = useSelector(vlanSelectors.loading);
   const subnets = useSelector((state: RootState) =>
-    subnetSelectors.getByIds(state, vlan?.subnet_ids || [])
+    subnetSelectors.getByIds(state, vlan?.subnet_ids || null)
   );
   useWindowTitle(`${vlan?.name || "VLAN"} details`);