Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(LXD): Link to VMs tab for single LXD hosts MAASENG-2412 #5216

Merged
merged 3 commits into from
Nov 24, 2023
Merged

fix(LXD): Link to VMs tab for single LXD hosts MAASENG-2412 #5216

merged 3 commits into from
Nov 24, 2023

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Nov 23, 2023 •
edited by petermakowski
Loading

Done

  • For LXD resources, replace machine table contextual menu with link to VMs tab
  • Remove test checking for machine fetch on KVM resources

QA steps

Using polong-ng as a backend:

  • Go to /kvm/lxd/2/resources
  • Click the link beneath the resources card, titled "Total VMs: XX"
  • Ensure you are redirected to the VMs tab for that host
  • Go to /kvm/virsh/3/resources
  • Click the same link
  • Ensure the mini machine list is displayed

Fixes

Fixes MAASENG-2412

@webteam-app
Copy link

Demo starting at https://maas-ui-5216.demos.haus

@ndv99 ndv99 force-pushed the MAASENG-2412-link-to-vms-tab branch from 4d9f6e1 to 9f0fdda Compare November 23, 2023 11:41
@petermakowski petermakowski enabled auto-merge (squash) November 24, 2023 08:25
@petermakowski petermakowski merged commit 3031600 into canonical:main Nov 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermakowski petermakowski petermakowski approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndv99 @webteam-app @petermakowski