Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable filter accordion for no items #5223

Merged
merged 2 commits into from
Nov 24, 2023
Merged

fix: disable filter accordion for no items #5223

merged 2 commits into from
Nov 24, 2023

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Nov 24, 2023 •
edited by Jay-Topher
Loading

Done

  • fix: disable filter accordion for no items

QA steps

  • Go to devices list
  • Given there are no devices, verify the filters dropdown is disabled
  • Add a new device (enter random MAC address)
  • Verify the filters dropdown has become active
  • Go to network discovery
  • Given there are active network discoveries, verify the filters dropdown is enabled

Screenshots

Google Chrome screenshot 001137@2x

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5223.demos.haus

Jay-Topher
Jay-Topher approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@Jay-Topher Jay-Topher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@petermakowski petermakowski enabled auto-merge (squash) November 24, 2023 14:56
dgtlntv
dgtlntv approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@dgtlntv dgtlntv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski petermakowski merged commit 0a1a355 into canonical:main Nov 24, 2023
5 checks passed
@petermakowski petermakowski deleted the fix-disable-filter-accordion-when-no-items branch May 9, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgtlntv dgtlntv dgtlntv approved these changes

@Jay-Topher Jay-Topher Jay-Topher approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petermakowski @webteam-app @Jay-Topher @dgtlntv