Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move SSH Key delete form to sidepanel #5291

Merged
merged 1 commit into from
Jan 19, 2024
Merged

feat: move SSH Key delete form to sidepanel #5291

merged 1 commit into from
Jan 19, 2024

Conversation

Jay-Topher
Copy link
Contributor

@Jay-Topher Jay-Topher commented Jan 18, 2024 •
edited by petermakowski
Loading

Done

  • moved SSH Key delete form to sidepanel

QA steps

  • visit /account/prefs/ssh-keys
  • If you don't have an SSH key added already, add one
  • Click on the delete button on the table row
  • ensure the side panel opens up to delete the SSH key
  • ensure deletion works

Fixes

Fixes: MAASENG-2576

Screenshots

Before

image

After

image

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5291.demos.haus

@Jay-Topher Jay-Topher force-pushed the MAASENG-2576-move-ssh-delete-to-sidepanel branch from 642af44 to 3831401 Compare January 19, 2024 11:27
petermakowski
petermakowski reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@petermakowski petermakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change and this should be ready to go.

src/app/preferences/components/Routes/Routes.tsx Outdated Show resolved Hide resolved
@Jay-Topher Jay-Topher force-pushed the MAASENG-2576-move-ssh-delete-to-sidepanel branch from 3831401 to 9b004a6 Compare January 19, 2024 13:29
@Jay-Topher Jay-Topher merged commit 74ecb1c into canonical:main Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermakowski petermakowski petermakowski approved these changes

@ndv99 ndv99 Awaiting requested review from ndv99

Assignees
No one assigned
Labels
Review: Code +1 (with changes) Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jay-Topher @webteam-app @petermakowski