feat: Add additional power field types for IP address, LXD, and Virsh

[ndv99]

Done

• Added LXD, Virsh, and IP address to power field types (in line with new backend types)
• Added simple IP address validaiton (check if field value is a valid IP address)

QA steps

• Go to a machine with IPMI power type (details page, "Configuration")
• Click "Edit" under "Power configuration"
• Ensure the IP address field is displayed correctly
• Type an invalid IP address into that field and press tab
• Ensure an error is displayed
• Go to machine list and click "Add machine"
• For power type, select [IPMI/LXD/Virsh]
• Ensure that the IP address field is displayed correctly
• Ensure that invalid IP addresses cause an error to be shown in this field

Screenshots

Before

After

Notes

The MP for the backend implementation of this is here

[webteam-app]

Demo

Jenkins

demos.haus

[ndv99]

Hm, I'm getting some real strange behavior in tests surrounding a couple of selectors

src/app/subnets/views/VLANDetails/VLANDetails.tsx:39:19

const subnets = useSelector((state: RootState) =>
    subnetSelectors.getByIds(state, vlan?.subnet_ids || [])
  );

src/app/machines/views/MachineDetails/MachineConfiguration/TagForm/TagForm.tsx:28:18

 const errors = useSelector((state: RootState) =>
    machineSelectors.eventErrorsForIds(state, systemId, [
      NodeActions.TAG,
      NodeActions.UNTAG,
    ])
  )[0]?.error;

Not quite sure what's causing these (or especially how it's related to this PR's changes), @petermakowski could you take a look if you have a minute?

[petermakowski]

Not quite sure what's causing these (or especially how it's related to this PR's changes), @petermakowski could you take a look if you have a minute?

#5448

[petermakowski]

Have you checked the bundle size impact of adding a new dependency?

[ndv99]

Have you checked the bundle size impact of adding a new dependency?

Good point - I'll run a before/after check. Although likelihood is we'll need this anyway for upcoming reserved IP work

[ndv99]

Have you checked the bundle size impact of adding a new dependency?

Good point - I'll run a before/after check. Although likelihood is we'll need this anyway for upcoming reserved IP work

Adding is-ip increases the (compressed) bundle size by 4066KiB

[amylily1011]

It looks like the IP address field didn't show up for me.

It looks like I'm in the correct branch

From https://github.com/canonical/maas-ui
 * [new ref]             refs/pull/5447/head -> feat-power-field-ip-validation
Switched to branch 'feat-power-field-ip-validation'

[ndv99]

It looks like the IP address field didn't show up for me.

It looks like I'm in the correct branch

From https://github.com/canonical/maas-ui
 * [new ref]             refs/pull/5447/head -> feat-power-field-ip-validation
Switched to branch 'feat-power-field-ip-validation'

Ahh - this is intended behaviour, my QA steps are wrong :) updated this to reflect expected functionality

[tmerten]

lgtm, QA done.

[tmerten]

Nice!