-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(subnets): Add support for reserved IPv6 addresses MAASENG-3162 #5453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app/subnets/views/SubnetDetails/StaticDHCPLease/ReserveDHCPLease/ReserveDHCPLease.tsx
Outdated
Show resolved
Hide resolved
src/app/subnets/views/SubnetDetails/StaticDHCPLease/ReserveDHCPLease/ReserveDHCPLease.tsx
Outdated
Show resolved
Hide resolved
src/app/subnets/views/SubnetDetails/StaticDHCPLease/ReserveDHCPLease/ReserveDHCPLease.test.tsx
Show resolved
Hide resolved
petermakowski
added
Review: Code +1 (with changes)
and removed
Review: Code needed
labels
Jun 6, 2024
Yeah, I noticed that too. Will investigate 👍 |
ndv99
force-pushed
the
MAASENG-3162-ipv6-support
branch
from
June 7, 2024 09:46
1fc6160
to
b67557e
Compare
petermakowski
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
is-ip
andipaddr.js
)delete
action to include the IP in the payload to match backend expectationsReserveDHCPLease
to be a little more sensibleQA steps
Ping me privately and I'll give you access to my container with the backend. Also, make sure the
VITE_APP_STATIC_IPS_ENABLED
is set totrue
./subnet/2/address-reservation
(this is an IPv6 subnet):1
orFFFF:FFFF:FFFF:FFFF
Fixes
Fixes MAASENG-3162
Screenshots
Notes
Figma design reference