Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subnets): Add support for reserved IPv6 addresses MAASENG-3162 #5453

Merged
merged 8 commits into from
Jun 7, 2024

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Jun 5, 2024

Done

  • Implemented new designs for IPv6 in the Add/Edit forms
  • Added validation for IPv6 (with help from is-ip and ipaddr.js)
  • Updated delete action to include the IP in the payload to match backend expectations
  • Re-ordered some of the code in ReserveDHCPLease to be a little more sensible

QA steps

Ping me privately and I'll give you access to my container with the backend. Also, make sure the VITE_APP_STATIC_IPS_ENABLED is set to true.

  • Go to /subnet/2/address-reservation (this is an IPv6 subnet)
  • Click on "Reserve static DHCP lease"
  • Ensure the routing prefix and subnet ID are displayed correctly
  • Ensure the placeholder is correct (should be four sets of "0000" separated by colons
  • Enter some text that definitely isn't an IPv6 interface ID
  • Ensure an error message is displayed
  • Remove that text
  • Ensure an error message "IP address is required" is displayed
  • Enter a valid IPv6 interface ID (e.g. :1 or FFFF:FFFF:FFFF:FFFF
  • Ensure no error messages are displayed and that the form can be submitted
  • Open the "Edit" form for the address you just reserved
  • Ensure the form pre-fills the address correctly

Fixes

Fixes MAASENG-3162

Screenshots

image

Notes

Figma design reference

@webteam-app
Copy link

@petermakowski
Copy link
Contributor

LGTM, one thing I noticed is that "Delete static DHCP lease" does not close on success.

Google Chrome screenshot 001952@2x

@ndv99
Copy link
Contributor Author

ndv99 commented Jun 6, 2024

LGTM, one thing I noticed is that "Delete static DHCP lease" does not close on success.

Yeah, I noticed that too. Will investigate 👍

@ndv99 ndv99 force-pushed the MAASENG-3162-ipv6-support branch from 1fc6160 to b67557e Compare June 7, 2024 09:46
@ndv99 ndv99 merged commit 5c99b01 into canonical:main Jun 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants