fix(images): Fallback as custom image when splitting OS from resource name #5581

abuyukyi101198 · 2025-01-16T16:55:59Z

Done

Set "custom" as the fallback for images that do not have the "os/release" naming format

… name

webteam-app · 2025-01-16T16:56:03Z

abuyukyi101198 is not a collaborator of the repo

…or splitResourceName tests

… could have parsable OS syntax

fix(images): fallback as custom image when splitting OS from resource…

e752999

… name

abuyukyi101198 added 3 commits January 16, 2025 20:26

test(images): edge case for empty image name, fixed expected values f…

bc347a8

…or splitResourceName tests

fix(images): replaced custom fallback with other, since custom images…

5f3bfc4

… could have parsable OS syntax

test(images): replaced custom fallback with other in tests

1496f37

abuyukyi101198 marked this pull request as ready for review January 17, 2025 08:52

ndv99 requested a review from dgtlntv January 17, 2025 12:36

ndv99 added Review: UX needed Review: Code needed Review: QA needed labels Jan 17, 2025

abuyukyi101198 assigned abuyukyi101198 and unassigned abuyukyi101198 Jan 17, 2025

abuyukyi101198 removed the request for review from dgtlntv January 20, 2025 15:27

abuyukyi101198 removed Review: QA needed Review: UX needed labels Jan 20, 2025

abuyukyi101198 requested a review from ndv99 January 20, 2025 15:27

ndv99 added Review: Code +1 and removed Review: Code needed labels Jan 20, 2025

ndv99 approved these changes Jan 21, 2025

View reviewed changes

abuyukyi101198 merged commit c7d6f7c into canonical:main Jan 21, 2025
7 of 8 checks passed

abuyukyi101198 deleted the fix-custom-image-os-name branch January 23, 2025 07:29