-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Update MAAS UI React ecosystem MAASENG-4477 #5621
chore(deps): Update MAAS UI React ecosystem MAASENG-4477 #5621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question inline
|
||
const upload = screen.getByLabelText(ScriptsUploadLabels.FileUploadArea); | ||
await userEvent.upload(upload, files); | ||
|
||
await waitFor(() => | ||
expect( | ||
screen.getByText("foo.sh (2000 bytes) ready for upload.") | ||
screen.getByText("./foo.sh (2000 bytes) ready for upload.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this ./
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test fails without it after the upgrades, probably react-dropzone
started parsing root level folders as such
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question inline
Done
Fixes
Resolves:
MAASENG-4477