Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update MAAS UI React ecosystem MAASENG-4477 #5621

Conversation

abuyukyi101198
Copy link
Contributor

@abuyukyi101198 abuyukyi101198 commented Feb 25, 2025

Done

Fixes

Resolves:

MAASENG-4477

@webteam-app
Copy link

@abuyukyi101198 abuyukyi101198 marked this pull request as ready for review February 25, 2025 07:58
@abuyukyi101198 abuyukyi101198 requested a review from ndv99 February 25, 2025 07:59
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question inline


const upload = screen.getByLabelText(ScriptsUploadLabels.FileUploadArea);
await userEvent.upload(upload, files);

await waitFor(() =>
expect(
screen.getByText("foo.sh (2000 bytes) ready for upload.")
screen.getByText("./foo.sh (2000 bytes) ready for upload.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this ./?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test fails without it after the upgrades, probably react-dropzone started parsing root level folders as such

Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question inline

@abuyukyi101198 abuyukyi101198 merged commit aa98aa0 into canonical:main Feb 25, 2025
9 checks passed
@abuyukyi101198 abuyukyi101198 deleted the chore-update-react-ecosystem-MAASENG-4477 branch February 25, 2025 08:27
@ndv99 ndv99 mentioned this pull request Feb 25, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants