Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint failures and add CI #143

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fix lint failures and add CI #143

merged 1 commit into from
Feb 18, 2025
+188 −137

Conversation

samuelallan72
Copy link
Contributor

@samuelallan72 samuelallan72 commented Feb 17, 2025 •
edited
Loading

Fixes: #142

@samuelallan72 samuelallan72 requested a review from a team as a code owner February 17, 2025 05:32
@samuelallan72 samuelallan72 changed the title Fix lint failures and add CI tests template Fix lint failures and add CI Feb 17, 2025
gabrielcocenza
gabrielcocenza approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@gabrielcocenza gabrielcocenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine because this project is only for maintenance and the changes are just to align with out lint tools.

I'm a little bit concerned about the usage of eventelet that is discouraged nowadays. If this wasn't in maintenance I think it would be better to use the prometheus python client .

@samuelallan72 samuelallan72 merged commit 2370f2c into main Feb 18, 2025
5 checks passed
@samuelallan72 samuelallan72 deleted the add-ci branch February 18, 2025 04:09
@samuelallan72 samuelallan72 mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielcocenza gabrielcocenza gabrielcocenza approved these changes

@chanchiwai-ray chanchiwai-ray chanchiwai-ray approved these changes

@Vultaire Vultaire Awaiting requested review from Vultaire Vultaire is a code owner automatically assigned from canonical/soleng-reviewers

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 is a code owner automatically assigned from canonical/soleng-reviewers

@Deezzir Deezzir Awaiting requested review from Deezzir Deezzir is a code owner automatically assigned from canonical/soleng-reviewers

@sbparke sbparke Awaiting requested review from sbparke sbparke is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix tests and add CI
3 participants
@samuelallan72 @gabrielcocenza @chanchiwai-ray