Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releases: add noble to azure dailys and UBUNTU_RELEASE_VERSION_MAP #328

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

blackboxsw
Copy link
Collaborator

No description provided.

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's a linting error to fix first.

For future reference (or discussion) I would only increment the patch number if it's a bug fix. Even though this is a very small improvement, I would consider it a change that should bump the minor number instead.

@blackboxsw
Copy link
Collaborator Author

There was an ordering issue w/ globbing files in the qemu unittests. Different versions of python order those files in differently. I added an explicit sorted to the list generated to ensure we always get the first lexicographic matching file in an image directory.

@blackboxsw blackboxsw merged commit b77d523 into canonical:main Dec 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants