feat(oracle): add kwargs to utility functions

[mjdonis]

No description provided.

[aciba90]

Apart from the version number, LGTM, thanks!

[aciba90]

I think we should reset the patch version to 0.

Suggested change

	1!5.13.1
	1!5.13.0

[TheRealFalcon]

Overall LGTM, but I do have one inline comment/question.

[TheRealFalcon]

I think this could lead to some somewhat weird call semantics. For example, with a call like

wait_till_ready(
            func=self.compute_client.get_instance,
            current_data=self.instance_data,
            desired_state="RUNNING",
            some_other_kwarg="mykwarg",
        )

it's not really obvious that some_other_kwarg is being used as an argument to the func. What if the function definition was instead something like

def wait_till_ready(
    func, current_data, func_kwargs: Dict, desired_state, sleep_seconds=1000
)

The call to the passed function then looks almost exactly the same:

current_data = func(current_data.id, **func_kwargs).data

but the callsite is a little more clear:

wait_till_ready(
            func=self.compute_client.get_instance,
            current_data=self.instance_data,
            desired_state="RUNNING",
            func_kwargs={"some_other_kwarg": "mykwarg"},
        )

Thoughts?

[mjdonis]

Changed the function arguments as suggested, and also added the necessary changes to the methods that use this function (and propagated the **kwargs definition to the base class and every child class to keep the signatures consistent)

[TheRealFalcon]

LGTM!

Identified issue was addressed