Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pyarrow support in find_column_type for pandas dataframes #313

Merged
merged 3 commits into from
Nov 19, 2024
Merged

add pyarrow support in find_column_type for pandas dataframes #313

merged 3 commits into from
Nov 19, 2024

Conversation

gladysteh99
Copy link
Contributor

  • first, check if datatype is a pd.ArrowDtype, if it is, call check_column_type_pyarrow to parse pyarrow-backed datatypes
  • else, parse as before

Fixes #282

@gladysteh99 gladysteh99 marked this pull request as ready for review November 19, 2024 21:24
jdawang
jdawang reviewed Nov 19, 2024
View reviewed changes
locopy/utility.py Outdated Show resolved Hide resolved
@jdawang jdawang self-requested a review November 19, 2024 22:05
@jdawang jdawang merged commit 6b0f1f8 into develop Nov 19, 2024
7 checks passed
@jdawang jdawang deleted the pyarrow branch November 19, 2024 22:05
@fdosani fdosani mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdawang jdawang jdawang approved these changes

@fdosani fdosani Awaiting requested review from fdosani fdosani is a code owner

@ak-gupta ak-gupta Awaiting requested review from ak-gupta ak-gupta is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

find_column_type not compatible with pyarrow backed data types
2 participants
@gladysteh99 @jdawang